refactor: allow infix notation for svelte modules #901
+161
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extension prebundling
bluwy
approved these changes
May 13, 2024
…simplifies regex and separates logic at cost of some code duplication)
bluwy
approved these changes
May 14, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and prevent custom extension prebundling
this would give users more flexibility when setting up tests or other tooling where they want to compile runes but the
.svelte.jsconvention would go against another convention (.test.js).You have to allow
.svelte.test.json our end or.test.svelte.json the test end. Given we are defining a new file format, making it play nice with existing ones feels like its the better way.Right now this is not limited to the second last segment, So
foo.svelte.bar.baz.qoox.jsmatches too.While doing this i saw that custom extensions were also used for prebundling. This has been removed because prebundling is only for libraries and these should never use custom extensions, otherwise we end up with fragmentation on the registry where users have to customize their svelte config to consume a library.