Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GamepadEventHandler type #9864

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

ntsd
Copy link
Contributor

@ntsd ntsd commented Dec 8, 2023

Add GamepadEventHandler type for window.addEventListener gamepadconnected and gamepaddisconnected

Ref: https://developer.mozilla.org/en-US/docs/Web/API/GamepadEvent

Same with #9861 but merge to Svelte 4

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Add GamepadEventHandler type for window.addEventListener `gamepadconnected` and `gamepaddisconnected`
Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: d032ff4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -1454,7 +1459,7 @@ export interface SVGAttributes<T extends EventTarget> extends AriaAttributes, DO
z?: number | string | undefined | null;
zoomAndPan?: string | undefined | null;

// allow any data- attribute
Copy link
Contributor Author

@ntsd ntsd Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one found after just auto format

@ntsd ntsd mentioned this pull request Dec 8, 2023
5 tasks
@trueadm
Copy link
Contributor

trueadm commented Dec 8, 2023

Need to fix lint issues :)

@ntsd
Copy link
Contributor Author

ntsd commented Dec 8, 2023

Need to fix lint issues :)

Line success on my local.

Seem like the Acron version update in this PR #9746 breaks the import

version: 8.11.2

$ pnpm run lint

> svelte-monorepo@0.0.1 lint /home/ntsd/git/ntsd/svelte
> cd packages/svelte && pnpm build && cd ../../ && pnpm -r lint


> svelte@4.2.8 build /home/ntsd/git/ntsd/svelte/packages/svelte
> rollup -c && pnpm types


src/compiler/index.js → compiler.cjs...
(!) Circular dependencies
src/compiler/compile/render_dom/wrappers/Fragment.js -> src/compiler/compile/render_dom/wrappers/AwaitBlock.js -> src/compiler/compile/render_dom/wrappers/Fragment.js
src/compiler/compile/nodes/shared/map_children.js -> src/compiler/compile/nodes/AwaitBlock.js -> src/compiler/compile/nodes/PendingBlock.js -> src/compiler/compile/nodes/shared/map_children.js
src/compiler/compile/nodes/ThenBlock.js -> src/compiler/compile/nodes/shared/get_const_tags.js -> src/compiler/compile/nodes/shared/map_children.js -> src/compiler/compile/nodes/AwaitBlock.js -> src/compiler/compile/nodes/ThenBlock.js
...and 18 more
created compiler.cjs in 1.8s

> svelte@4.2.8 types /home/ntsd/git/ntsd/svelte/packages/svelte
> node ./scripts/generate-dts.js

Scope: 3 of 4 workspace projects
packages/svelte lint$ prettier . --cache --plugin-search-dir=. --check && eslint "{scripts,src,test}/**/*.js" --cache
│ Checking formatting...
│ All matched files use Prettier code style!
└─ Done in 5.1s

.changeset/fair-eagles-wink.md Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 804f296 into sveltejs:svelte-4 Dec 11, 2023
5 of 8 checks passed
@dummdidumm
Copy link
Member

The Acorn thing is unrelated and happening for a while now. I'll look into this the coming days

@github-actions github-actions bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants