Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: This makes the indeterminate HTML attribute available for use. Fixes #9176. #9180

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

paulreece
Copy link
Contributor

@paulreece paulreece commented Sep 5, 2023

Before submitting the PR, please make sure you do the following

  • [X ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [ X] Prefix your PR title with feat:, fix:, chore:, or docs:.
  • [ X] This message body should clearly illustrate what problems it solves.
  • [ X] Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • [X ] Run the tests with pnpm test and lint the project with pnpm lint

Fixes #9176. This adds indeterminate to the list of HTMLAttributes so that one can use it without receiving an error.

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

🦋 Changeset detected

Latest commit: 3c08ec4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paulreece paulreece force-pushed the indeterminate_addition branch 3 times, most recently from f40f1c0 to 3e2f888 Compare September 6, 2023 01:45
@paulreece
Copy link
Contributor Author

@jasonlyu123 Please let me know if I can do anything else in regards to this pull request.

@jasonlyu123
Copy link
Member

jasonlyu123 commented Sep 13, 2023

Oh I forgot about it. As the bot commented, this needs a changeset.

@paulreece
Copy link
Contributor Author

Just added one, thank you!

.changeset/ten-poems-remember.md Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 6fe17ea into sveltejs:master Sep 20, 2023
6 of 7 checks passed
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
kelvinsjk pushed a commit to kelvinsjk/svelte that referenced this pull request Oct 19, 2023
…ixes sveltejs#9176. (sveltejs#9180)

Fixes sveltejs#9176. This adds indeterminate to the list of HTMLAttributes so that one can use it without receiving an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation error with input indeterminate
3 participants