chore: unbundled esm #8613
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,78 +3,67 @@ | |
| "version": "4.0.0-next.0", | ||
| "description": "Cybernetically enhanced web apps", | ||
| "type": "module", | ||
| "module": "src/runtime/index.js", | ||
| "main": "src/runtime/index.js", | ||
| "files": [ | ||
| "src", | ||
|
There was a problem hiding this comment. we should separate the There was a problem hiding this comment. If copying over the changes, There was a problem hiding this comment. Thanks for catching that. I updated #8523 to address that |
||
| "types", | ||
| "compiler.*", | ||
| "register.js", | ||
| "index.d.ts", | ||
| "internal.d.ts", | ||
| "store.d.ts", | ||
| "animate.d.ts", | ||
| "transition.d.ts", | ||
| "easing.d.ts", | ||
| "motion.d.ts", | ||
| "action.d.ts", | ||
| "elements.d.ts", | ||
|
Comment on lines
+13
to
+21
There was a problem hiding this comment. Are these needed in addition to the exports map because of the moduleResolution thing? |
||
| "README.md" | ||
| ], | ||
| "exports": { | ||
| "./package.json": "./package.json", | ||
| ".": { | ||
| "types": "./types/runtime/index.d.ts", | ||
| "browser": { | ||
| "import": "./src/runtime/index.js" | ||
| }, | ||
| "import": "./src/runtime/ssr.js" | ||
| }, | ||
| "./compiler": { | ||
| "types": "./types/compiler/index.d.ts", | ||
| "import": "./src/compiler/index.js", | ||
| "require": "./compiler.cjs" | ||
| }, | ||
| "./action": { | ||
| "types": "./types/runtime/action/index.d.ts" | ||
| }, | ||
| "./animate": { | ||
| "types": "./types/runtime/animate/index.d.ts", | ||
| "import": "./src/runtime/animate/index.js" | ||
| }, | ||
| "./easing": { | ||
| "types": "./types/runtime/easing/index.d.ts", | ||
| "import": "./src/runtime/easing/index.js" | ||
| }, | ||
| "./internal": { | ||
| "types": "./types/runtime/internal/index.d.ts", | ||
| "import": "./src/runtime/internal/index.js" | ||
| }, | ||
| "./motion": { | ||
| "types": "./types/runtime/motion/index.d.ts", | ||
| "import": "./src/runtime/motion/index.js" | ||
| }, | ||
| "./store": { | ||
| "types": "./types/runtime/store/index.d.ts", | ||
| "import": "./src/runtime/store/index.js" | ||
| }, | ||
| "./transition": { | ||
| "types": "./types/runtime/transition/index.d.ts", | ||
| "import": "./src/runtime/transition/index.js" | ||
| }, | ||
| "./elements": { | ||
| "types": "./elements.d.ts" | ||
| } | ||
| }, | ||
| "engines": { | ||
|
|
@@ -88,9 +77,9 @@ | |
| "build": "rollup -c && npm run tsd", | ||
| "prepare": "npm run build", | ||
| "dev": "rollup -cw", | ||
| "posttest": "agadoo src/internal/index.js", | ||
| "prepublishOnly": "npm run lint && npm run build && npm test", | ||
| "tsd": "node ./generate-types.js", | ||
| "lint": "eslint \"{src,test}/**/*.{ts,js}\" --cache" | ||
| }, | ||
| "repository": { | ||
|
|
@@ -109,50 +98,45 @@ | |
| "url": "https://github.com/sveltejs/svelte/issues" | ||
| }, | ||
| "homepage": "https://svelte.dev", | ||
| "dependencies": { | ||
| "@ampproject/remapping": "^2.2.1", | ||
| "@jridgewell/sourcemap-codec": "^1.4.15", | ||
| "acorn": "^8.8.2", | ||
| "aria-query": "^5.1.3", | ||
| "axobject-query": "^3.1.1", | ||
| "code-red": "^1.0.0", | ||
| "css-tree": "^2.3.1", | ||
| "estree-walker": "^3.0.3", | ||
| "is-reference": "^3.0.1", | ||
| "locate-character": "^2.0.5", | ||
| "magic-string": "^0.30.0", | ||
| "periscopic": "^3.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@playwright/test": "^1.33.0", | ||
| "@rollup/plugin-commonjs": "^24.1.0", | ||
| "@rollup/plugin-json": "^6.0.0", | ||
| "@rollup/plugin-node-resolve": "^15.0.2", | ||
| "@rollup/plugin-replace": "^5.0.2", | ||
| "@sveltejs/eslint-config": "^6.0.1", | ||
| "@types/aria-query": "^5.0.1", | ||
| "@types/estree": "^1.0.0", | ||
| "@types/node": "^14.14.31", | ||
| "@typescript-eslint/eslint-plugin": "^5.58.0", | ||
| "agadoo": "^3.0.0", | ||
| "esbuild": "^0.17.19", | ||
| "eslint": "^8.40.0", | ||
| "eslint-plugin-import": "^2.27.5", | ||
| "eslint-plugin-svelte": "^2.28.0", | ||
| "eslint-plugin-unicorn": "^47.0.0", | ||
| "happy-dom": "^9.18.3", | ||
| "jsdom": "^21.1.1", | ||
| "kleur": "^4.1.5", | ||
| "prettier": "^2.8.8", | ||
| "prettier-plugin-svelte": "^2.10.0", | ||
| "rollup": "^3.20.2", | ||
| "source-map": "^0.7.4", | ||
| "tiny-glob": "^0.2.9", | ||
| "typescript": "^5.0.4", | ||
| "util": "^0.12.5", | ||
| "vitest": "^0.31.1" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a comment explaining why this needs to be ignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
!means it's not ignored, which it was previously 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, duh. the format of this file is rather peculiar where it ignores everything in the root directory by default and then only opts files in. I wonder if we could swap that once the CJS version is removed