Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set verison to 4, remove engines.pnpm and bump engines.node to >=16 #8566

Merged
merged 5 commits into from May 8, 2023

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented May 7, 2023

HEADS UP: BIG RESTRUCTURING UNDERWAY

The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot on the compiler aswell. For that reason, please don't open PRs that are large in scope, touch more than a couple of files etc. In other words, bug fixes are fine, but feature PRs will likely not be merged.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@vercel
Copy link

vercel bot commented May 7, 2023

@dominikg is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@benmccann benmccann added this to the 4.x milestone May 8, 2023
@dummdidumm dummdidumm changed the title fix: set verison to 4, remove engines.pnpm and bump engines.node to >=18 fix: set verison to 4, remove engines.pnpm and bump engines.node to >=16 May 8, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 56df761 into sveltejs:version-4 May 8, 2023
11 of 12 checks passed
@gtm-nayan gtm-nayan mentioned this pull request Jun 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants