[fix] set auto-subscription to undefined when update store to falsy value #7693
Conversation
tanhauhau
force-pushed
the
tanhauhau/gh-7555
branch
from
d741000
to
8611af9
Compare
| export function subscribe_dynamic_store(store, callback) { | ||
| if (store == null) { | ||
| callback(undefined); | ||
| return noop; | ||
| } | ||
| const unsub = store.subscribe(callback); | ||
| return unsub.unsubscribe ? () => unsub.unsubscribe() : unsub; | ||
| } |
There was a problem hiding this comment.
[ask]
This is a question but why did you create the new function?
Why adding callbacks.forEach(callback => callback(undefined)); to subscribe is not good?
There was a problem hiding this comment.
sorry didn't understand the question.
You are saying using what statement instead of which function?
There was a problem hiding this comment.
Already we have subscribe function.
And the difference between subscribe_dynamic_store and subscribe is only line number 77. (callback(undefined);)
So I thought that we can update subscribe without creating the new function subscribe_dynamic_store.
But I believe you have a reason why subscribe_dynamic_store is necessary. So I would like to know about it.
There was a problem hiding this comment.
Hmm.. I can't remember why I did that.
I know we need to call callback(undefined) so that when store changed to undefined, we should update $store to undefined too.
The subscribe was used when it assumes that the store variable is static, so does not need to call callback to set the $store to undefined.
But let me look at it again and see if I can reuse the code.
|
Close in favor of #7947 |
Fixes #7555
Before submitting the PR, please make sure you do the following
[feat],[fix],[chore], or[docs].Tests
npm testand lint the project withnpm run lint