Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate reassigned deriveds to $derived #15581

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

paoloricciuti
Copy link
Member

Since now deriveds are writable we can properly migrate even reassigned labeled statements...i did add a check for the version so that in older versions we migrate to compatible code but maybe that's unnecessary?

Also i still migrate this

$: something = 43;

to state because it's better.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
Copy link

changeset-bot bot commented Mar 21, 2025

🦋 Changeset detected

Latest commit: 39fef24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti paoloricciuti marked this pull request as ready for review March 21, 2025 21:39
@svelte-docs-bot
Copy link

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rich-Harris Rich-Harris merged commit 33d118f into main Mar 21, 2025
13 of 16 checks passed
@Rich-Harris Rich-Harris deleted the migrate-reassigned-deriveds branch March 21, 2025 22:47
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15581

This was referenced Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants