Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure transient writes to tracked parent effects works as expected #15506

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 13, 2025

Fixes #15499. We need to ensure that if there was a previous active reaction and we have untracked writes, that we propagate those writes to that reaction too.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: 6003d9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15506

trueadm and others added 3 commits March 13, 2025 18:53
@Rich-Harris Rich-Harris changed the title ix: ensure transient writes to tracked parent effects works as expected fix: ensure transient writes to tracked parent effects works as expected Mar 13, 2025
@trueadm trueadm merged commit 5d3aa2b into main Mar 13, 2025
13 checks passed
@trueadm trueadm deleted the untracked-effect-pre branch March 13, 2025 19:49
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$effect.pre isn't re-run after mutating state in a nested $effect.pre
2 participants