-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: don't distribute unused types definitions #15473
Conversation
🦋 Changeset detectedLatest commit: 9ab2793 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
types/index.d.ts.map
is included for a reason. I'm pretty sure interfaces.d.ts
and preprocess.d.ts
are needed for backwards compatibility
This is also missing all the other legacy top level d.ts files. We can only remove those inside |
|
There are some I don't see used still, but I might not be familiar with how TypeScript load these. E.g. I don't see any reference to |
These files are crucial for when you have a tsconfig that have a setting that makes typescript ignore the export map. Then it just looks as the file system, so when you do |
results in a smaller package. don't need to distribute unused files
this may close (or not, we'll see) #15182