fix : bug "$0 is not defined" with svelte:element and a single class with a function call #15396
+88
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -83,9 +83,12 @@ export function SvelteElement(node, context) { | |||
| if ( | |||
| attributes.length === 1 && | |||
| attributes[0].type === 'Attribute' && | |||
| attributes[0].name.toLowerCase() === 'class' | |||
| attributes[0].name.toLowerCase() === 'class' && | |||
| attributes[0].value !== true && | |||
There was a problem hiding this comment.
I might be wrong but there should be a is_text_attrobute utility somewhere...can you check if that's the case and use that?
There was a problem hiding this comment.
Will change that in the morning
🦋 Changeset detectedLatest commit: 22c5338 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/svelte/src/compiler/phases/3-transform/client/visitors/SvelteElement.js
Show resolved
Hide resolved
trueadm
approved these changes
Feb 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced this bug with the set_class() PR #15352 :(
This fix it...
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint