fix: Allow global-like pseudo-selectors refinement #15313
Merged
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7aeeeb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
For instance, specifying a tree-structural pseudo-class to `::view-transition-new` should still constitute a valid global-like selector. Fixes sveltejs#15312
|
dummdidumm
reviewed
Mar 14, 2025
packages/svelte/src/compiler/phases/2-analyze/css/css-analyze.js
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance, specifying a tree-structural pseudo-class to
::view-transition-newshould still constitute a valid global-like selector.Fixes #15312
This PR tweaked some tests, which wouldn't pass before but do now; however they're far from being exhaustive, as I'm sure this needs a little bit of thinking.
Secondly, this PR introduced a fix that's certainly way too broad in scope, additionally and "accidentally" allowing
:hostas well to be re-specified. Frankly, there may be quite a bit to discuss there.Or we can start by having a specific exception for
:only-childonly, and solely for::view-transition-new()and::view-transition-old(), as at least these combinations seem to be legitimate.pnpm testwent fine; the linting one failed to run... but it's nearly midnight and I'm fairly confident my changes so far would pass.Please don't hesitate to engage in the discussion, I'll happily tweak this preliminary commit and am well aware that it certainly isn't just right as of now :)