Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly match :has()'s selector during css pruning #15277

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

7nik
Copy link
Contributor

@7nik 7nik commented Feb 12, 2025

Fixes #14072, alternative of #15207

:has() was matching only against descendants or siblings, but not sibling's descendants.

In this variant, I made apply_selector and related functions bidirectional. So the same logic can be applied to all selectors.
Changing the direction for selectors passed into :has() broke p:has(+ y) for the test has-with-render-tag and to fix it I added diving into the @render() tags during gathering siblings, which fixed the render-tag-loop test.

I also tried to cache the function retrieving neighbor elements and got the following cache hits rates on the test cases:
descendant_forward: 94,23%
descendant_backward: 55,91%
children_forward: 84,00%
children_backward: 33,51%
sibling_forward: 69,42%
sibling_backward: 59,94%
next_forward: 41,40%
next_backward: 2,44%
Though, I'm not sure how to measure performance change.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
bflad Brian Flad
Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 6b71df2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15277

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seriously impressive work. Thank you!

Feel free to open a separate PR with the cache, I can investigate a bit how much of a perf difference it makes.

@svelte-docs-bot
Copy link

@dummdidumm dummdidumm merged commit 8e9a21e into sveltejs:main Mar 14, 2025
8 checks passed
@github-actions github-actions bot mentioned this pull request Mar 14, 2025
@7nik
Copy link
Contributor Author

7nik commented Mar 15, 2025

I was a bit busy and not sure how to properly benchmark, so eventually didn't get to it.

@7nik 7nik deleted the fix-css-has branch March 15, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sibling Combinator combined with :has can be improperly marked as unused
2 participants