-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: when re-connecting unowned deriveds, remove their unowned flag #15255
Conversation
🦋 Changeset detectedLatest commit: 8a952ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks @trueadm, you're amazing! This resolves the 4 LayerChart regressions identified in techniq/layerchart#384 (tested locally with |
this pr also fixes #15180 |
@trueadm all regressions appear to still be fixed after re-running |
The simplification on props actually introduced other issues, so the previous fix was indeed correct. Thanks for you help! |
Fixes #15229.
Fixes #15180.
Where we know that an unowned that was temporarily made unowned, and has definitely become owned again, we can remove the unowned flag entirely. This is the inverse of the logic that makes the derived temporarily unowned to begin with.