Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: never consider inert boundary effects #14999

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

paoloricciuti
Copy link
Member

Closes #14994

Thanks to @trueadm for the guidance (he actually solved the bug in #14998 ...we then talked a bit and since this seemed a better alternative we switched to this).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
ocelotl Diego Hurtado
Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: fec2c20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14999-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14999

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@paoloricciuti paoloricciuti merged commit 8a1acac into main Jan 13, 2025
11 checks passed
@paoloricciuti paoloricciuti deleted the fix-failed-snippet-reactivity branch January 13, 2025 21:17
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactivity is lost when the failed snippet of a svelte:boundary is rendered
3 participants