Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bindable prop validation #14946

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 8, 2025

Possible alternative to #13416

closes #13368

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Playground

pnpm add https://pkg.pr.new/svelte@14946

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 3e1c7c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit ce4f972 into main Jan 8, 2025
11 checks passed
@Rich-Harris Rich-Harris deleted the remove-binding-validation branch January 8, 2025 14:54
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
@fasterthanlime
Copy link

fasterthanlime commented Feb 25, 2025

I'm fairly sure that this broke vite-plugin-svelte — they depend on an older svelte compiler, which still generates the calls to $.validate_prop_bindings, resulting in errors like $.validate_prop_bindings is not a function (Something that had zero web search results until my comment 🙃)

❯ npm ls svelte -a
fasterthanli-me@1.0.0 /Users/amos/bearcove/fasterthanli.me
├─┬ lithkit@1.0.0 -> ./../lithkit
│ └─┬ @sveltejs/vite-plugin-svelte@5.0.3
│   ├─┬ @sveltejs/vite-plugin-svelte-inspector@4.0.1
│   │ └── svelte@5.0.3 deduped
│   └── svelte@5.0.3
└── svelte@5.20.4

I'm going to look into opening a PR to vite-plugin-svelte, but it would be nice to do synchronized releases of bundler pulgins when changing the internals in a non-backwards compatible way like this.

Afaict this broke in a minor version, I couldn't find any trace within the changelog, I spent hours tracking it down and getting rid of dependencies I thought were shipping pre-built Svelte components. (Although there are such dependencies out there and they will break as well.)


On second thought this went out as 5.17.1 on Jan 8... has nobody else really noticed anything for 49 days?

Edit 2: no PR needed, the vite-plugin-svelte repo already depends on a recent enough svelte, it just needs a release to be cut.

Edit 3: opened sveltejs/vite-plugin-svelte#1090 to request a publish/release — sorry for the noise here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runes: cannot optionally bind: to a component's prop if not exported
3 participants