chore: provide links to documentation for errors/warnings #14629
+417
−389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 68281fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
dummdidumm
force-pushed
the
warn-error-links
branch
from
919d142 to
1e8be19
Compare
Rich-Harris
reviewed
Dec 9, 2024
| @@ -339,7 +339,7 @@ function transform(name, dest) { | |||
| }; | |||
|
|
|||
| for (let i = 0; i < node.expressions.length; i += 1) { | |||
| const q = node.quasis[i + 1]; | |||
| const q = structuredClone(node.quasis[i + 1]); | |||
There was a problem hiding this comment.
(reverting it doesn't cause any tests to fail)
There was a problem hiding this comment.
Revert it and rebuild the generated messages then you'll see it - later code does mutate properties and that can pollute the node across codes
Rich-Harris
approved these changes
Dec 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11305
Companion PR: sveltejs/svelte.dev#965