Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leave update expressions untransformed unless a transformer is provided #14507

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

Rich-Harris
Copy link
Member

Fixes part of #14495

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…rovided
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 8a808ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14507

@Rich-Harris Rich-Harris marked this pull request as draft December 2, 2024 19:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Rich-Harris Rich-Harris marked this pull request as ready for review December 2, 2024 20:30
@Rich-Harris Rich-Harris linked an issue Dec 2, 2024 that may be closed by this pull request
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes part of #14495

... but in the issue you say "seems all are fixed". So ... this closes the issue completely?

@Rich-Harris
Copy link
Member Author

Yes, marked as such here:

image

@Rich-Harris Rich-Harris merged commit aac929d into main Dec 3, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the gh-14495 branch December 3, 2024 18:08
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odd issues with $state and non-$state BigInts
2 participants