Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable bound store props in runes mode components #13887

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 24, 2024

Closes #13825.

This is an interesting one.

  1. In legacy mode, we allow bound stores to persist and have their properties update – however, you get a warning that you're writing to a non-reactive property when doing so – this removes that warning as things work fine.
  2. In runes mode, we allow bound store subs to work like they do in legacy mode. We do this by marking the bound store sub inside the prop getter and then capturing this and using this logic to apply the different heuristics.

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 43dc147

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm trueadm merged commit 771b1e8 into main Oct 24, 2024
7 checks passed
@trueadm trueadm deleted the compat-bound-store-sub branch October 24, 2024 21:12
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: binding_property_non_reactive when binding to a writable store
2 participants