Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace declaration property of SvelteConstTag with declarations property #641

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Jan 14, 2025

See #620 (comment)

close #620

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…ions` property
Copy link

pkg-pr-new bot commented Jan 14, 2025

Open in Stackblitz

npm i https://pkg.pr.new/svelte-eslint-parser@641

commit: 36c4016

@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12765146330

Details

  • 17 of 21 (80.95%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 94.72%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/converts/const.ts 11 15 73.33%
Totals Coverage Status
Change from base Build 12742361209: -0.02%
Covered Lines: 10344
Relevant Lines: 10798

💛 - Coveralls

Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 36c4016

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Should we also make a PR for eslint-plugin-svelte and release it at the same time as this PR?

@ota-meshi
Copy link
Member Author

I plan to work on the changes I commented in sveltejs/eslint-plugin-svelte#992 next, but since this package is currently in pre-release I think it's okay to release it frequently.

@baseballyama baseballyama merged commit 89e053a into main Jan 14, 2025
13 checks passed
@baseballyama baseballyama deleted the change-const branch January 14, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants