fix: recognize script as module for Typescript type checking #604
+1,710
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6055811 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
baseballyama
commented
Dec 1, 2024
| @@ -95,7 +95,6 @@ | |||
| "eslint-plugin-regexp": "^2.7.0", | |||
| "eslint-plugin-svelte": "^2.46.1", | |||
| "eslint-plugin-yml": "^1.15.0", | |||
| "estree-walker": "^3.0.3", | |||
There was a problem hiding this comment.
I think we don't use this dependency.
baseballyama
commented
Dec 1, 2024
| @@ -380,7 +398,7 @@ function analyzeRuneVariables( | |||
| // See https://github.com/sveltejs/svelte/blob/41b5cd6f5daae3970a9927e062f42b6b62440d16/packages/svelte/types/index.d.ts#L2615 | |||
| case "$props": { | |||
| // Use type parameters to avoid `@typescript-eslint/no-unsafe-assignment` errors. | |||
| appendDeclareFunctionVirtualScripts(globalName, ["<T>(): T"]); | |||
| appendDeclareFunctionVirtualScripts(globalName, ["(): any"]); | |||
There was a problem hiding this comment.
Now $props doesn't have generics.
There was a problem hiding this comment.
But 1 test is failed, so I reverted it.
There was a problem hiding this comment.
Yeah, this is intentionally typed differently than Svelte core.
Pull Request Test Coverage Report for Build 12102873057Details
💛 - Coveralls |
baseballyama
commented
Dec 1, 2024
Comment on lines
+83
to
+87
| // When performing type checking on TypeScript code that is not a module, the error `Cannot redeclare block-scoped variable 'xxx'`. occurs. To fix this, add an `export`. | ||
| // see: https://github.com/sveltejs/svelte-eslint-parser/issues/557 | ||
| if (!hasExportDeclaration(result.ast)) { | ||
| appendDummyExport(ctx); | ||
| } |
There was a problem hiding this comment.
Here is main part of this PR.
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #557
This PR adjusts the script to always be recognized as a module. This ensures that the error “Cannot redeclare block-scoped variable ‘xxx’” does not occur.