Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experimental support for generics directive #477

Merged
merged 11 commits into from Mar 3, 2024
Merged

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Feb 24, 2024

close #306
close sveltejs/eslint-plugin-svelte#521

generics are not yet marked as experimental features in this parser (Parsing of generics is not opt-in and is always enabled), but before official release, generics should be made experimental if they are still undocumented.

To use it you need to set parserOptions.svelteFeatures.experimentalGenerics to true.

Copy link

changeset-bot bot commented Feb 24, 2024

🦋 Changeset detected

Latest commit: 81e4201

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ota-meshi ota-meshi force-pushed the generic branch 3 times, most recently from c35cc70 to 35bfb04 Compare February 24, 2024 12:36
@coveralls
Copy link

coveralls commented Feb 24, 2024

Pull Request Test Coverage Report for Build 8127749354

Details

  • 181 of 190 (95.26%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 91.604%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/context/script-let.ts 86 89 96.63%
src/context/fix-locations.ts 30 36 83.33%
Totals Coverage Status
Change from base Build 8094321933: 0.1%
Covered Lines: 2625
Relevant Lines: 2771

💛 - Coveralls

@ota-meshi ota-meshi marked this pull request as ready for review February 24, 2024 12:40
@ota-meshi ota-meshi changed the title feat: add support for generics directive feat: add experimental support for generics directive Feb 25, 2024
@ota-meshi ota-meshi merged commit 5f2b111 into main Mar 3, 2024
13 checks passed
@ota-meshi ota-meshi deleted the generic branch March 3, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic declarations in components not recognized by ESLint Support Svelte's $$Generic type
2 participants