Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve props type #435

Merged
merged 2 commits into from
Nov 21, 2023
Merged

feat: improve props type #435

merged 2 commits into from
Nov 21, 2023

Conversation

ota-meshi
Copy link
Member

This PR gives the attribute the correct type information.
This allows onxxx handlers to also have the correct type information.

related to #423

Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: c1ae837

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Nov 20, 2023

Pull Request Test Coverage Report for Build 6931279438

  • 27 of 28 (96.43%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 91.485%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/converts/attr.ts 24 25 96.0%
Totals Coverage Status
Change from base Build 6926134270: 0.07%
Covered Lines: 2463
Relevant Lines: 2605

💛 - Coveralls

@ota-meshi ota-meshi merged commit 7508680 into main Nov 21, 2023
14 checks passed
@ota-meshi ota-meshi deleted the event-type-svelte-5 branch November 21, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants