Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect location when there is whitespace at the beginning of block #434

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Nov 20, 2023

This PR fixes incorrect location when there is whitespace at the beginning of block.

This PR adds a test case when there is a line break in the blocks.
This is an example of location not being calculated properly in Svelte v5.

Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: ec1c995

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ota-meshi ota-meshi changed the title test: add newline in blocks test cases fix: incorrect location when there is whitespace at the beginning of block Nov 21, 2023
Copy link
Contributor

github-actions bot commented Nov 21, 2023

Pull Request Test Coverage Report for Build 6937764852

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 91.475%

Totals Coverage Status
Change from base Build 6926134270: 0.06%
Covered Lines: 2453
Relevant Lines: 2594

💛 - Coveralls

@ota-meshi ota-meshi marked this pull request as ready for review November 21, 2023 01:00
@ota-meshi ota-meshi merged commit 0ef067b into main Nov 21, 2023
14 checks passed
@ota-meshi ota-meshi deleted the add-newline-in-blocks-test-cases branch November 21, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants