Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply runes to *.svelte.js and *.svelte.ts #426

Merged
merged 15 commits into from
Nov 17, 2023
Merged

feat: apply runes to *.svelte.js and *.svelte.ts #426

merged 15 commits into from
Nov 17, 2023

Conversation

ota-meshi
Copy link
Member

Related to #423

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2023 •
edited

🦋 Changeset detected

Latest commit: 36afeb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Nov 15, 2023 •
edited

Pull Request Test Coverage Report for Build 6901746254

  • 140 of 149 (93.96%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 91.261%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/parser-options.ts 29 31 93.55%
src/parser/typescript/analyze/index.ts 49 56 87.5%
Totals Coverage Status
Change from base Build 6900086632: 0.2%
Covered Lines: 2324
Relevant Lines: 2463
💛 - Coveralls

@ota-meshi ota-meshi mentioned this pull request Nov 15, 2023
Merged
@ota-meshi ota-meshi marked this pull request as draft November 17, 2023 03:06
@ota-meshi ota-meshi changed the title feat: add svelteFeatures.runes option and add rune symbols to global scope feat: apply runes to *.svelte.js and *.svelte.ts Nov 17, 2023
baseballyama
baseballyama reviewed Nov 17, 2023
View reviewed changes
tests/fixtures/parser/ast/svelte-5-preview/docs/fine-grained-reactivity/example01-input.svelte Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can reuse these tests because already I added these.

@ota-meshi ota-meshi marked this pull request as ready for review November 17, 2023 08:21
baseballyama
baseballyama approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

@ota-meshi ota-meshi merged commit 9793cb0 into main Nov 17, 2023
14 checks passed
@ota-meshi ota-meshi deleted the runes-vars branch November 17, 2023 08:44
@github-actions github-actions bot mentioned this pull request Nov 17, 2023
Merged
@ota-meshi ota-meshi mentioned this pull request Nov 17, 2023
Open
16 tasks
@github-actions github-actions bot mentioned this pull request Apr 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baseballyama baseballyama baseballyama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ota-meshi @coveralls @baseballyama