feat: add type of $effect.active (#441)

sveltejs · Nov 25, 2023 · 34232c5 · 34232c5
1 parent 6e67241
commit 34232c5
Show file tree

Hide file tree

Showing 2 changed files with 67 additions and 52 deletions.
diff --git a/.changeset/nine-pandas-fly.md b/.changeset/nine-pandas-fly.md
@@ -0,0 +1,5 @@
+---
+"svelte-eslint-parser": minor
+---
+
+feat: add type of `$effect.active`
diff --git a/src/parser/typescript/analyze/index.ts b/src/parser/typescript/analyze/index.ts
@@ -313,27 +313,30 @@ function analyzeRuneVariables(
     }
     switch (globalName) {
       case "$state": {
-        appendDeclareFunctionVirtualScript(globalName, "<T>(initial: T): T");
-        appendDeclareFunctionVirtualScript(globalName, "<T>(): T | undefined");
+        appendDeclareFunctionVirtualScripts(globalName, [
+          "<T>(initial: T): T",
+          "<T>(): T | undefined",
+        ]);
         break;
       }
       case "$derived": {
-        appendDeclareFunctionVirtualScript(globalName, "<T>(expression: T): T");
+        appendDeclareFunctionVirtualScripts(globalName, [
+          "<T>(expression: T): T",
+        ]);
         break;
       }
       case "$effect": {
-        appendDeclareFunctionVirtualScript(
-          globalName,
+        appendDeclareFunctionVirtualScripts(globalName, [
           "(fn: () => void | (() => void)): void",
-        );
-        appendDeclareNamespaceVirtualScript(
-          globalName,
+        ]);
+        appendDeclareNamespaceVirtualScripts(globalName, [
           "export function pre(fn: () => void | (() => void)): void;",
-        );
+          "export function active(): boolean;",
+        ]);
         break;
       }
       case "$props": {
-        appendDeclareFunctionVirtualScript(globalName, "<T>(): T");
+        appendDeclareFunctionVirtualScripts(globalName, ["<T>(): T"]);
         break;
       }
       default: {
@@ -344,56 +347,63 @@ function analyzeRuneVariables(
   }
 
   /** Append declare virtual script */
-  function appendDeclareFunctionVirtualScript(name: string, type: string) {
-    ctx.appendVirtualScript(`declare function ${name}${type};`);
-    ctx.restoreContext.addRestoreStatementProcess((node, result) => {
-      if (
-        node.type !== "TSDeclareFunction" ||
-        !node.declare ||
-        node.id?.type !== "Identifier" ||
-        node.id.name !== name
-      ) {
-        return false;
-      }
-      const program = result.ast;
-      program.body.splice(program.body.indexOf(node), 1);
+  function appendDeclareFunctionVirtualScripts(name: string, types: string[]) {
+    for (const type of types) {
+      ctx.appendVirtualScript(`declare function ${name}${type};`);
+      ctx.restoreContext.addRestoreStatementProcess((node, result) => {
+        if (
+          node.type !== "TSDeclareFunction" ||
+          !node.declare ||
+          node.id?.type !== "Identifier" ||
+          node.id.name !== name
+        ) {
+          return false;
+        }
+        const program = result.ast;
+        program.body.splice(program.body.indexOf(node), 1);
 
-      const scopeManager = result.scopeManager as ScopeManager;
+        const scopeManager = result.scopeManager as ScopeManager;
 
-      // Remove `declare` variable
-      removeAllScopeAndVariableAndReference(node, {
-        visitorKeys: result.visitorKeys,
-        scopeManager,
-      });
+        // Remove `declare` variable
+        removeAllScopeAndVariableAndReference(node, {
+          visitorKeys: result.visitorKeys,
+          scopeManager,
+        });
 
-      return true;
-    });
+        return true;
+      });
+    }
   }
 
-  function appendDeclareNamespaceVirtualScript(name: string, script: string) {
-    ctx.appendVirtualScript(`declare namespace $effect { ${script} }`);
-    ctx.restoreContext.addRestoreStatementProcess((node, result) => {
-      if (
-        node.type !== "TSModuleDeclaration" ||
-        !node.declare ||
-        node.id?.type !== "Identifier" ||
-        node.id.name !== name
-      ) {
-        return false;
-      }
-      const program = result.ast;
-      program.body.splice(program.body.indexOf(node), 1);
+  function appendDeclareNamespaceVirtualScripts(
+    name: string,
+    scripts: string[],
+  ) {
+    for (const script of scripts) {
+      ctx.appendVirtualScript(`declare namespace ${name} { ${script} }`);
+      ctx.restoreContext.addRestoreStatementProcess((node, result) => {
+        if (
+          node.type !== "TSModuleDeclaration" ||
+          !node.declare ||
+          node.id?.type !== "Identifier" ||
+          node.id.name !== name
+        ) {
+          return false;
+        }
+        const program = result.ast;
+        program.body.splice(program.body.indexOf(node), 1);
 
-      const scopeManager = result.scopeManager as ScopeManager;
+        const scopeManager = result.scopeManager as ScopeManager;
 
-      // Remove `declare` variable
-      removeAllScopeAndVariableAndReference(node, {
-        visitorKeys: result.visitorKeys,
-        scopeManager,
-      });
+        // Remove `declare` variable
+        removeAllScopeAndVariableAndReference(node, {
+          visitorKeys: result.visitorKeys,
+          scopeManager,
+        });
 
-      return true;
-    });
+        return true;
+      });
+    }
   }
 }