-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow bypassing invalidateAll
in enhance
#9889
Conversation
🦋 Changeset detectedLatest commit: 8742429 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…tejs/kit into elliott/9476-allow-no-invalidateAll
oops, wrong branch This reverts commit a9ae11b.
Hmm. I'm not sure I love this pattern of adding more options to With hindsight I sort of wish we hadn't added the |
Let's either choose to do this or close this PR. I'm for merging it (not because I'm the author, just because it's useful) -- I agree we can probably come up with a better / more declarative API for v2, but this is, IMO, a good solution for now. |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Closes #9476.
Adds an
invalidateAll
option to the callback fromenhance
. Setting this option tofalse
will causeenhance
not to skip the invalidation step.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.