-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: realign state.branch on the client on hydration #9754
Conversation
🦋 Changeset detectedLatest commit: e82ca92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…into compaction-troubles
|
||
// server-side will have compacted the branch, reinstate empty slots | ||
// so that error boundaries can be lined up correctly | ||
if (parsed_route) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having this additional code to un-compact it, wouldn't it be less code to not compact the branch server-side for the initial request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to litter quite a few null checks to do it from the server side, cb3dcde
I was thinking it'd better to have slightly more code in a perma-cached asset than adding empty slots for the node_ids and the corresponding server data nodes in every SSR'ed response.
fixes #9745
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.