Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix path to app script on windows #9743

Merged
merged 1 commit into from
May 4, 2023

Conversation

gtm-nayan
Copy link
Contributor

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

As noted on discord, in dev mode the hydration script inserted into pages is rendered as
import("./D:\\some\\path\\kit\\sites\\kit.svelte.dev\\.svelte-kit/generated/client/app.js")

which works for our current intents and purposes, hence why this is marked as a chore instead of a fix, but it just looks plain weird and might confuse users.

This PR makes it so that these paths have correct facing slashes and the /@fs/ prefix on both Linux and Windows.

Sorry, something went wrong.

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2023

🦋 Changeset detected

Latest commit: 4d659d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gtm-nayan gtm-nayan marked this pull request as ready for review April 25, 2023 10:54
@gtm-nayan
Copy link
Contributor Author

oops forgot to take this out of draft

@Conduitry
Copy link
Member

What effect does this have on end-users? I'd argue that, in general, chore: PRs shouldn't have changesets. Either it's a fix for a user-visible bug, or it's an internal refactoring that we don't need to tell users about and that we don't want Changesets to prompt us to cut a release for.

@gtm-nayan
Copy link
Contributor Author

It was bordering between a fix and a chore for me. Both chrome and firefox find the file somehow even with the dot and the slashes so marked it as a chore instead. Should I remove the changeset then?

@Rich-Harris
Copy link
Member

i think it's okay to err on the side of too many changesets — for stuff like this which does have user-observable changes (albeit changes they hopefully won't notice) there's no harm in being able to pin down the version where it changed in the unlikely eventuality that it causes problems for someone

also i'm about to cut a release so it doesn't matter too much

@Rich-Harris Rich-Harris merged commit 7e52391 into master May 4, 2023
@Rich-Harris Rich-Harris deleted the windows-app-script-path branch May 4, 2023 02:41
@github-actions github-actions bot mentioned this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants