fix: tsconfig includes being a level higher than they should be

[gtm-nayan]

closes #8872
closes #8898

• removed project_relative cause the paths are already resolved to be absolute when the config is processed
• also fixes the other problem mentioned in tsconfig contains duplicate include entries #8872 (comment), which was caused by project_relative returning an empty string for any folder directly inside the project directory, so config_relative was pointing to /**/*.js
• had to add a special case for src because otherwise it'd be a breaking change

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

[dummdidumm]

Makes sense! I adjusted the v2 comment because frankly I don't think we can remove that logic for v2, and deduplicated paths some more

[wvhulle]

For me it seems like there are multiple extra levels, not just one. Is this also solved with this pull request?

[gtm-nayan]

Yep, see second bullet from the PR description.

[wvhulle]

It is not solved yet on master branch. Do you want to see a reproduction?

[wvhulle]

[path.resolve('src')].filter((dir) => {
    const relative = path.relative(path.resolve('src'), dir);
    return !relative || relative.startsWith('..');
});

always returns src even though it doesn't exist. Is this intended?

[wvhulle]

const config = {
		preprocess: vitePreprocess(),

		kit: {
			env: { dir: "../" },
			alias: {
				$lib: "../lib"
			},
			files: {
				assets: "../static",
				hooks:  { client: './hooks.client', server: './hooks.server' },
				lib: "../lib",
				params: "../lib/params",
				routes: './routes',
				appTemplate: `../static/app.html`
			},
			outDir: `/home/[omitted]/cache/dev/main/kit`,
			adapter: adapter({ out: "build" })
		}
	};

generates

   "include": [
   	"ambient.d.ts",
   	"./types/**/$types.d.ts",
   	"../../../../main/vite.config.ts",
   	"../../../../../../../../../**/*.js",
   	"../../../../../../../../../**/*.ts",
   	"../../../../../../../../../**/*.svelte",
   	"../../../../**/*.js",
   	"../../../../**/*.ts",
   	"../../../../**/*.svelte",
   	"../../../../main/tests/**/*.js",
   	"../../../../main/tests/**/*.ts",
   	"../../../../main/tests/**/*.svelte"
   ],

[wvhulle]

After going through your code it seems like the problem is not in the code adding the includes but in the parsing of the config.

A reproduction is in https://github.com/wvhulle/sveltekit-bug-write-tsconfig.json

[wvhulle]

Sorry, I didn't properly update to the latest commit. I now see it works. Reverting to version 1.5.0 brings back the problem. My only remark is that the src is included even though. How do I make sure the kit version i reference is the one from github? I used pnpm add -D github:sveltejs/kit but then I had to manually find the path of the function sveltekit in node_modules.