Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use resolve_symlinks for node.universal and node.server #12740

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

yukipastelcat
Copy link
Contributor

@yukipastelcat yukipastelcat commented Oct 1, 2024

This PR seems to fix following issue with symbolic links in the routes #8100
Minimal issue reproduction is available here: https://github.com/yukipastelcat/sveltekit-symlinks
Symbolic links in the reproduction repository will be created automatically during build, but my plugin is flaky, so you might need to run npm run build for the second time to reproduce the issue.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

pnpm test command does not exist, so I ran pnpm test:kit instead, some tests are failing, but they also do it in the main branch.

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 25df6eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino
Copy link
Member

eltigerchino commented Oct 6, 2024

Thanks! The repro works well and I've tested the fix with it. Can you add a test for this? Maybe in one of the other test suite folders we could try to make it so the build fails? Otherwise, it looks good to me.

Co-authored-by: Tee Ming <chewteeming01@gmail.com>
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symlink tests are close to impossible to write in a good way (for example there's one I believe which always fails on windows for me), so I'm ok with this not having a test

@dummdidumm dummdidumm merged commit 34a03ff into sveltejs:main Jan 16, 2025
14 checks passed
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants