fix: ignore warning binding non reactive #12524
Merged
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Generate static _routes in Cloudflare adapter * Update .changeset/ten-shirts-add.md * fix: add comements and newline in generated _redirects file * fix: exclude redirect paths from cloudflare * fix: check if there are redirects before writing * Fix formatting --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 7a280a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paoloricciuti
changed the title
dummdidumm
reviewed
Jul 31, 2024
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
dummdidumm
approved these changes
Aug 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #12484 after the work in sveltejs/svelte#12608
This will double the warnings in versions of svelte 5 before
5.0.0-next.204but it should clear them after that. Once again at least locally i see some test fails that seems to be completely unrelated. Let's wait for the release of 204 before merging this obviously.For the moment i've left the test there but maybe we should remove it since in older versions it will actually throw more warnings?
EDIT: just tested it locally and i realized you are not doubling the warning since the svelte ignore warning is at compile time
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits