-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: precompress filter #10185
fix: precompress filter #10185
Conversation
🦋 Changeset detectedLatest commit: 853d02a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You beat me to the punch! Only other issue here is that the tiny glob function returned absolute paths which list_files
does not, breaking compress_file
. I initially fixed that with .map(f => resolve(directory, f))
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
import { fileURLToPath } from 'node:url'; | ||
import { expect, test } from 'vitest'; | ||
import { assert, expect, test } from 'vitest'; | ||
import glob from 'tiny-glob/sync.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this work still? is this test actually being run or is it being pulled in as a transitive dependency from some other package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had me spinning around for a good 15 minutes. Turns out it's a workspace dependency so it's available in all packages in the repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I wonder if that caused us not to notice some of these issues because it was available there, but not in end user projects
would you mind removing it as a workspace dependency? you can make it a devDependency
of this project. we've tried to avoid workspace dependencies in favor of per-project dependencies except for stuff like eslint and prettier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What package should become a devDependency
? Lost on context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oop, forgot about this one, tiny-glob should be moved to the kit devDependencies instead of workspace but I think we can just get rid of it altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you do that so we can finish and merge the PR?
closes #10184
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.