Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove scrollbars on default error page #10059

Merged
merged 2 commits into from
Jun 5, 2023
Merged

fix: remove scrollbars on default error page #10059

merged 2 commits into from
Jun 5, 2023

Conversation

jaylinski
Copy link
Contributor

Description

The CSS rule body { height: 100vh } on the default error-page will cause vertical scrollbars if the default body-margin isn't removed.

I didn't include a changelog because it is such a minor change. (But I can add one if you want.)

How to test

Open @sveltejs/kit/src/core/config/default-error.html and verify that there are no vertical scrollbars.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Sorry, something went wrong.

The CSS rule `body { height: 100vh }` will cause vertical
scrollbars if the default body-margin isn't removed.
@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023

🦋 Changeset detected

Latest commit: 4725ab0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann changed the title fix: Remove scrollbars on default error-page fix: remove scrollbars on default error page May 30, 2023
@jaylinski
Copy link
Contributor Author

@benmccann Thanks for adding the changeset 🙌

@benmccann benmccann merged commit 551f6c9 into sveltejs:master Jun 5, 2023
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
@jaylinski jaylinski deleted the patch-1 branch June 5, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants