fix: disallow exporting actions from a +layout.server file

[eltigerchino]

Found out we can export actions in a layout file but it isn't mentioned anywhere in the docs.
I don't think we're suppose to export actions from a layout file. #10046 (comment)

This PR changes the list of valid exports to disallow the actions export from a +layout.server file (matching the language tools behaviour).

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

[changeset-bot]

🦋 Changeset detected

Latest commit: 58cd9c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[david-plugge]

I don´t think you can do that. Vscode gives me this error:

Invalid export 'actions' (valid exports are prerender, ssr, csr, trailingSlash, config, load, or anything with a '_' prefix

[eltigerchino]

Huh. That's weird. It's suppose to be valid based on the code here:

kit/packages/kit/src/utils/exports.js

Line 72 in f8cf1fe

const valid_layout_server_exports = new Set([...valid_layout_exports, 'actions']);

and it's tested here

kit/packages/kit/src/utils/exports.spec.js

Lines 114 to 118 in f8cf1fe

	check_error(() => {
	validate_layout_server_exports({
	answer: 42
	});
	}, "Invalid export 'answer' (valid exports are load, prerender, csr, ssr, trailingSlash, config, actions, or anything with a '_' prefix)");

[eltigerchino]

Not sure if we need to update language tools to allow actions in layout or update kit to disallow actions in layout.
https://github.com/sveltejs/language-tools/blob/98b925617bbdbf6e9e51a1d7e229d0f27c2337cc/packages/typescript-plugin/src/language-service/sveltekit.ts#L280-L281

[david-plugge]

I wonder how actions in layout files would work, specifically how you would call them from the client (what to put in the form action attribute?). Page and layout actions could collide, how would the server choose between src/routes/#layout.server.ts#actions.signin and src/routes/#page.server.ts#actions.signin ?

[elliott-with-the-longest-name-on-github]

I... would expect you shouldn't export actions from layout components? I have no idea what URL they would / should live at.