Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preload inline docs #10037

Merged
merged 2 commits into from
May 25, 2023
Merged

fix preload inline docs #10037

merged 2 commits into from
May 25, 2023

Conversation

Rich-Harris
Copy link
Member

borderline whether this needs a changeset, but since it affects the inline documentation on hover i figured we may as well. supersedes #10036

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2023

🦋 Changeset detected

Latest commit: 3612036

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these docs are correct and the ones in https://kit.svelte.dev/docs/hooks#server-hooks-handle are outdated

const preload_types = ['js', 'css', 'font'];

@Rich-Harris
Copy link
Member Author

The docs are incorrect. The code above shows the types of things that can be preloaded, which includes font; this is about what things are preloaded by default, which does not (and should not) include font

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, this is what I should have linked to:

const default_preload = ({ type }) => type === 'js' || type === 'css';

I looked way too quickly at the other file, which wasn't even part of sveltekit, but kit.svelte.dev 😝

Verified

This commit was signed with the committer’s verified signature.
jbedard Jason Bedard
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants