Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rule types #735

Merged
merged 10 commits into from
Apr 11, 2024
Merged

feat: add rule types #735

merged 10 commits into from
Apr 11, 2024

Conversation

xiBread
Copy link
Contributor

@xiBread xiBread commented Apr 10, 2024

Fixes #707

This PR deviates slightly from the original request; instead of supporting eslint-define-config, this directly augments ESLint's Linter.FlatConfig type:

Screenshot 2024-04-10 at 7 14 42 PM

This relies on eslint-typegen. I've added a new build script in order to preserve the comments in this rule-types.d.ts file since tsconfig.build.json removes them (if there's a better way to do this then please let me know).

Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: e0b8690

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I didn't know we could do that with type definitions.

package.json Outdated Show resolved Hide resolved
src/rule-types.d.ts Outdated Show resolved Hide resolved
src/rule-types.d.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 33f0de2 into sveltejs:main Apr 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship types for eslint-define-config
2 participants