fix: false positives for custom-element with svelte v3 in svelte/valid-compile
#604
+34
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 60a56e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
baseballyama
reviewed
Nov 3, 2023
| warnings: Warning[]; | ||
| kind: 'warn' | 'error'; | ||
| } { | ||
| try { | ||
| const result = compiler.compile(code, { | ||
| generate: false, | ||
| ...(semver.satisfies(compiler.VERSION, '>=4.0.0-0') ? { customElement: true } : {}) | ||
| ...(semver.satisfies(compiler.VERSION, '>=4.0.0-0') | ||
| ? { customElement: true } |
There was a problem hiding this comment.
[ask]
Why always we can set { customElement: true } if Svelte version is 4?
There was a problem hiding this comment.
In v3, if customElement:true is set, a warning will be returned if <svelte:options tag> is missing, but in v4, there will be no warning even if <svelte:options customElement> is missing.
baseballyama
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #602