feat: add ignorePropertyPatterns property and rename ignorePatterns to ignoreTypePatterns in no-unused-props rule
#1132
+213
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0619c15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
baseballyama
force-pushed
the
feat/enhance-no-unused-props
branch
4 times, most recently
from
336e654 to
893166c
Compare
baseballyama
force-pushed
the
feat/enhance-no-unused-props
branch
from
893166c to
425d233
Compare
baseballyama
force-pushed
the
feat/enhance-no-unused-props
branch
from
842fdad to
e28d8cf
Compare
…s` to `ignoreTypePatterns` in `no-unused-props` rule
baseballyama
force-pushed
the
feat/enhance-no-unused-props
branch
from
e28d8cf to
435691b
Compare
|
I’ll merge this before US working hours start to minimize the impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reconsidering, merging #1135 should also resolve the branded types issue. This is because branded types typically originate from external libraries, meaning their properties are externally defined and should thus be fixed by #1135.
Therefore, this becomes a purely additive feature. However, I still think it’s beneficial to allow ignoring patterns based on both type names and properties.
-> I tested this in a project that uses branded types and confirmed that it’s fixed as expected.