Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance] update go-structr and go-mutexes with memory usage improvements #2909

Conversation

NyaaaWhatsUpDoc
Copy link
Member

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc commented May 7, 2024

Description

Updates:

  • go-mutexes -> v1.5.0, mutex map now performs self-compaction if reduced in size by loadFactor / 2, also uses swiss hashmap implementation
  • go-structr -> v0.8.4 uses swiss hashmap implementation, compacts specifically queue indices if reduced in size by loadFactor / 2, fix for loading cache entry items in LoadOne(), other unrelated (for us) fix

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as ready for review May 8, 2024 09:34
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit c06e6fb into superseriousbusiness:main May 13, 2024
2 checks passed
mohan43u pushed a commit to mohan43u/gotosocial that referenced this pull request May 13, 2024
…ovements (superseriousbusiness#2909)

* update go-structr and go-mutexes with memory usage improvements

* bump to go-structr v0.8.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant