Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update gin to v1.9.0 #1553

Merged
merged 1 commit into from Feb 25, 2023

Conversation

daenney
Copy link
Member

@daenney daenney commented Feb 25, 2023

Description

This updates Gin to its latest release.

There is one breaking change in there, but I don't think it would negatively affect us in any way: gin-gonic/gin#2150

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

That "breaking" change is actually welcomed!! When looking through my logs I end up with plenty of those entries 😅

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit ecdc837 into superseriousbusiness:main Feb 25, 2023
@daenney daenney deleted the update-gin branch February 25, 2023 12:35
@tsmethurst
Copy link
Contributor

Oh nice yeah, that's great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants