Add support for astral-sh/ruff

[Okabe-Junya]

Proposed changes

• add support for astral-sh/ruff

Fix #5384

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

• I included all the needed documentation for this change.
• I provided the necessary tests.
• I squashed all the commits into a single commit.
• I followed the Conventional Commit v1.0.0 spec.
• I wrote the necessary upgrade instructions in the upgrade guide.
• If this pull request is about and existing issue,
  I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

• Label as breaking if this change breaks compatibility with the previous released version.
• Label as either: automation, bug, documentation, enhancement, infrastructure.

BEGIN_COMMIT_OVERRIDE
feat: add support for astral-sh/ruff (#5456), closes #5384
END_COMMIT_OVERRIDE

[ferrarimarco]

Thanks for this PR! A couple of minor things to check. I'll also run CI workflows, and see what they say :)

[Okabe-Junya]

Thank you @ferrarimarco for reviewing!!

I fixed CI error and commented. PTAL again, thank you 💙

[ferrarimarco]

@Okabe-Junya we're almost there!

As a last change, can you please make the tests shorter? There's likely no need to include these big files. Maybe 3-4 lines each are enough.

Thanks!

[Okabe-Junya]

Thank you @ferrarimarco

Your review is very sensible. However, other Python tools are (mostly) using the same test files. I think we should not prepare a completely different test file just for ruff now.

FYI:

• black: https://github.com/super-linter/super-linter/tree/main/test/linters/python_black
• pylint: https://github.com/super-linter/super-linter/tree/main/test/linters/python_pylint
• flake8: https://github.com/super-linter/super-linter/tree/main/test/linters/python_flake8
• mypy: https://github.com/super-linter/super-linter/tree/main/test/linters/python_mypy

Meaning, if we are to change to test files of about 3-4 lines, shouldn't we do the same for the other files as well? And, I think this change is beyond the scope of this PR.

thank you 💙

[ferrarimarco]

Thank you @ferrarimarco

Your review is very sensible. However, other Python tools are (mostly) using the same test files. I think we should not prepare a completely different test file just for ruff now.

FYI:

• black: https://github.com/super-linter/super-linter/tree/main/test/linters/python_black
• pylint: https://github.com/super-linter/super-linter/tree/main/test/linters/python_pylint
• flake8: https://github.com/super-linter/super-linter/tree/main/test/linters/python_flake8
• mypy: https://github.com/super-linter/super-linter/tree/main/test/linters/python_mypy

Meaning, if we are to change to test files of about 3-4 lines, shouldn't we do the same for the other files as well? And, I think this change is beyond the scope of this PR.

thank you 💙

Hi! There's no need for the test files to be aligned. In fact, we should reduce the size of the others as well, but this is out of scope for this PR, as you said. We can start with these ones, tho.

Thanks for your contributions!

[Okabe-Junya]

Thanks!!

but this is out of scope for this PR, as you said. We can start with these ones, tho.

I would like to work on updating the test files after this PR is merged :)

First, I will focus on merging this PR. I think that addressing the CI errors is what needs to be done. I will investigate the cause of the CI failures...

[ferrarimarco]

Sorry, I mistyped. I meant: we can start with the ones in this PR. :)

thanks a lot!

[Okabe-Junya]

I have investigated similar PRs to resolve CI error. #4925 seems to be one of them.

Upon careful investment, I realized that I did not write code like LINTER_NAMES_ARRAY['CHECKOV']="checkov". However, such code does not exist in lib/linter.sh.

When I used "grep" to check the code, I found that it had been moved to scripts/linterVersions.sh in #5197. This means that I need to make a simple modification to scripts/linterVersions.sh.

[Okabe-Junya]

I believe now ALL CI will pass...

[Okabe-Junya]

I have fixed to the test files, and all CI checks have passed in the forked repo!!

FYI: https://github.com/Okabe-Junya/super-linter/actions/runs/8568038203

[ferrarimarco]

One small thing to check and we should be good to go! Thanks for all this work @Okabe-Junya !

[Okabe-Junya]

Thank you for reviewing this many times. I have checked!

[Okabe-Junya]

Thank you for your Considerate and kind support @ferrarimarco 💙 Looking forward to release!!

[ferrarimarco]

Thanks for all your work @Okabe-Junya !