Issue checkstyle#3110: Modified DefaultLogger to remove hardcoded mes…

…sages and to support i18n for the messages
subkrish · Jun 26, 2017 · ef48dd5 · ef48dd5
1 parent 61f2ef2
commit ef48dd5
Showing 1 changed file with 30 additions and 3 deletions.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/DefaultLogger.java b/src/main/java/com/puppycrawl/tools/checkstyle/DefaultLogger.java
@@ -28,6 +28,7 @@
 import com.puppycrawl.tools.checkstyle.api.AuditEvent;
 import com.puppycrawl.tools.checkstyle.api.AuditListener;
 import com.puppycrawl.tools.checkstyle.api.AutomaticBean;
+import com.puppycrawl.tools.checkstyle.api.LocalizedMessage;
 import com.puppycrawl.tools.checkstyle.api.SeverityLevel;
 
 /**
@@ -42,6 +43,22 @@
  */
 public class DefaultLogger extends AutomaticBean implements AuditListener {
 
+    /**
+     * A key pointing to the add exception
+     * message in the "messages.properties" file.
+     */
+    public static final String ADD_EXCEPTION_MESSAGE = "DefaultLogger.addException";
+    /**
+     * A key pointing to the started audit
+     * message in the "messages.properties" file.
+     */
+    public static final String AUDIT_STARTED_MESSAGE = "DefaultLogger.auditStarted";
+    /**
+     * A key pointing to the finished audit
+     * message in the "messages.properties" file.
+     */
+    public static final String AUDIT_FINISHED_MESSAGE = "DefaultLogger.auditFinished";
+
     /** Where to write info messages. **/
     private final PrintWriter infoWriter;
     /** Close info stream after use. */
@@ -127,20 +144,30 @@ public void addError(AuditEvent event) {
     @Override
     public void addException(AuditEvent event, Throwable throwable) {
         synchronized (errorWriter) {
-            errorWriter.println("Error auditing " + event.getFileName());
+            final LocalizedMessage addExceptionMessage = new LocalizedMessage(0,
+                Definitions.CHECKSTYLE_BUNDLE, ADD_EXCEPTION_MESSAGE,
+                new String[] {event.getFileName()}, null,
+                LocalizedMessage.class, null);
+            errorWriter.println(addExceptionMessage.getMessage());
             throwable.printStackTrace(errorWriter);
         }
     }
 
     @Override
     public void auditStarted(AuditEvent event) {
-        infoWriter.println("Starting audit...");
+        final LocalizedMessage auditStartMessage = new LocalizedMessage(0,
+            Definitions.CHECKSTYLE_BUNDLE, AUDIT_STARTED_MESSAGE, null, null,
+            LocalizedMessage.class, null);
+        infoWriter.println(auditStartMessage.getMessage());
         infoWriter.flush();
     }
 
     @Override
     public void auditFinished(AuditEvent event) {
-        infoWriter.println("Audit done.");
+        final LocalizedMessage auditFinishMessage = new LocalizedMessage(0,
+            Definitions.CHECKSTYLE_BUNDLE, AUDIT_FINISHED_MESSAGE, null, null,
+            LocalizedMessage.class, null);
+        infoWriter.println(auditFinishMessage.getMessage());
         closeStreams();
     }