Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreLonghands: [] to declaration-block-no-redundant-longhand-properties #7611

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

Mouvedia
Copy link
Member

@Mouvedia Mouvedia commented Apr 14, 2024

Which issue, if any, is this issue related to?

Closes #7232

Is there anything in the PR that needs further explanation?

To understand why a fix is being accompanied by an option check the discussion starting with #7232 (comment)

tl;dr: CSS Text Decoration Module Level 3 vs CSS Text Decoration Module Level 4 means that a granular option is necessary for the text-decoration fix not be considered a downgrade

Copy link

changeset-bot bot commented Apr 14, 2024

🦋 Changeset detected

Latest commit: 4c9912e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ybiquitous ybiquitous changed the title Add ignoreLonghands option to declaration-block-no-redundant-longhand-properties Add ignoreLonghands: [] to declaration-block-no-redundant-longhand-properties Apr 17, 2024
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. Can you address my comments?

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍🏼

@Mouvedia
Copy link
Member Author

Mouvedia commented Apr 17, 2024

@ybiquitous @jeddy3 I would advise to add "ignoreLonghands": ["text-decoration-thickness"] to https://github.com/stylelint/stylelint-config-standard/blob/3c610c147cc6c20b9e24292ff002b4637d55d3bc/index.js#L55

@ybiquitous
Copy link
Member

I would advise to add "ignoreLonghands": ["text-decoration-thickness"]

Hum, this example on MDN makes sense, right?

.thick {
  text-decoration: solid underline purple 4px; /* includes `text-decoration-thickness: 4px` */
}

@Mouvedia
Copy link
Member Author

Mouvedia commented Apr 18, 2024

It does if you consider that 95%+ support on caniuse is enough. If not it would be better to ignore text-decoration-thickness so that standard doesn't change.

@ybiquitous
Copy link
Member

It does if you consider that 95%+ support on caniuse is enough.

I think the percentage is enough for now. Let's keep things simple. If people complain, then we can revisit it.

@Mouvedia
Copy link
Member Author

@ybiquitous

error - 2024-04-18 12:59:34,223 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 136 seconds."}
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

@ybiquitous
Copy link
Member

Have you merge the commit fca3269 into this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add "ignoreLonghands": [] to declaration-block-no-redundant-longhand-properties
2 participants