Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
ignoreSelectors: []
toselector-max-compound-selectors
#7544Add
ignoreSelectors: []
toselector-max-compound-selectors
#7544Changes from 16 commits
b7d7782
006aad8
e436252
480c433
a84db08
6b1e807
da72434
1df6e37
5f4c119
0cba157
e174fc5
371dee6
9779746
af3d404
83e7f1a
8643580
91c2a8e
411ed1e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question
major
How should
'.foo .baz .bar.quz {}'
behave for2
ignore[".bar", ".quz"]
?i.e. does it remove one by one from the compound selector or does it skip it if it's not exactly a match?
Either way is fine with me but it needs to be documented either with a
> [!NOTE]
or an example in the README.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FloEdelmann ping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #7544 (review)