Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive CJS deprecation warning for dual-package plugins #7532

Merged
merged 14 commits into from
Mar 8, 2024
Merged

Fix false positive CJS deprecation warning for dual-package plugins #7532

merged 14 commits into from
Mar 8, 2024
+199 −43

Commits on Mar 7, 2024

  1. fix: replace resolve-from with import-meta-resolve for dual package 

    close #7460
    @JounQin
    JounQin committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    713c26b View commit details
    Browse the repository at this point in the history

  2. chore: skip transform lib/utils/getModulePath.mjs to commonjs

    @JounQin
    JounQin committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5a341d2 View commit details
    Browse the repository at this point in the history

  3. chore: reset unexpected commonjs files after building

    @JounQin
    JounQin committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    7c735c7 View commit details
    Browse the repository at this point in the history

  4. chore: lib/utils/getModulePath.cjs will be maintained manually later

    @JounQin
    JounQin committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    cf5e008 View commit details
    Browse the repository at this point in the history

  5. chore: use moduleResolve instead

    @JounQin
    JounQin committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    eaa6771 View commit details
    Browse the repository at this point in the history

  6. refactor: extract resolveSilent

    @JounQin
    JounQin committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    3c912f7 View commit details
    Browse the repository at this point in the history

  7. refactor: migrate to @dual-bundle/import-meta-resolve

    @JounQin
    JounQin committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    4ae82d1 View commit details
    Browse the repository at this point in the history

  8. Update .changeset/clean-needles-deliver.md

    @JounQin
    JounQin committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    aa07397 View commit details
    Browse the repository at this point in the history

  9. chore: add some TODO comments

    @JounQin
    JounQin committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9ec87b6 View commit details
    Browse the repository at this point in the history

  10. fix: add missing conditions param

    @JounQin
    JounQin committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    bebcc68 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. test: add resolveSilent test case

    @JounQin
    JounQin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a836e90 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @JounQin @ybiquitous
    JounQin and ybiquitous committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a60dbec View commit details
    Browse the repository at this point in the history

  3. refactor: change to use resolve instead of moduleResolve

    @JounQin
    JounQin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    9b86300 View commit details
    Browse the repository at this point in the history

  4. chore: move resolveSilent test case

    @JounQin
    JounQin committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8911631 View commit details
    Browse the repository at this point in the history