Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-pseudo-*-allowed-list false positives for vendor prefixes #7525

Conversation

carlosjeurissen
Copy link
Contributor

Closes #7524

Copy link

changeset-bot bot commented Feb 17, 2024

🦋 Changeset detected

Latest commit: 847cbc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ybiquitous ybiquitous changed the title Make vendor prefixes in allowed-list functional Fix selector-pseudo-*-allowed-list false positives for vendor prefixes Feb 19, 2024
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlosjeurissen Thanks for the pull request. The code changes look good to me. In addition, can you add minimum test cases?

@carlosjeurissen carlosjeurissen deleted the fix/pseudo-allowed-list/vendor-prefixes branch February 19, 2024 14:16
@carlosjeurissen carlosjeurissen restored the fix/pseudo-allowed-list/vendor-prefixes branch February 19, 2024 14:18
@carlosjeurissen
Copy link
Contributor Author

@ybiquitous Sure! Added the tests!

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍🏼

@ybiquitous ybiquitous merged commit c49f9b5 into stylelint:main Feb 20, 2024
27 checks passed
@carlosjeurissen carlosjeurissen deleted the fix/pseudo-allowed-list/vendor-prefixes branch February 20, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix selector-pseudo-*-allowed-list false positives for vendor prefixes
2 participants