Fix function-calc-no-unspaced-operator performance
#7505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the broken benchmark script (`npm run benchmark`)
The error reason is that `rules[ruleName]` has returned a `Promise` since 16.0.0.
```sh-session
$ npm run benchmark-rule -- value-keyword-case lower
...
const rule = ruleFunc(primary, secondary, context);
^
TypeError: ruleFunc is not a function
...
```
Also, this changes `parserOptions.ecmaVersion` in the ESLint config to allow top-level `await`.
How to measure: ```shell npm run -s benchmark-rule -- function-calc-no-unspaced-operator true ``` Before: ``` Warnings: 0 Mean: 125.72145828571429 ms Deviation: 14.960783775263804 ms ``` After: ``` Warnings: 0 Mean: 110.21394642857142 ms Deviation: 10.1318139617483 ms ```
🦋 Changeset detectedLatest commit: cebe29f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
romainmenke
reviewed
Jan 30, 2024
romainmenke
approved these changes
Jan 30, 2024
|
@romainmenke Thanks for the quick review! Can you take a quick look at #7504, too? It's a blocker for this PR. |
ybiquitous
deleted the
fix-function-calc-no-unspaced-operator-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6923
Wait for #7504 (Note that the base branch is
fix-benchmark-script)How to measure:
npm run -s benchmark-rule -- function-calc-no-unspaced-operator trueBefore:
After: