Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function-no-unknown|value-keyword-case false positives for template literals with line breaks #7443

Merged
merged 2 commits into from Jan 8, 2024

Conversation

Sh031224
Copy link
Contributor

@Sh031224 Sh031224 commented Jan 4, 2024

Which issue, if any, is this issue related to?

#7442

Is there anything in the PR that needs further explanation?

The regular expression that checks template literals in js has been changed.

Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: da9c762

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Sh031224 Sh031224 changed the title Fix: Template literal behavior with line breaks is incorrect Fix: Template literal behavior with line breaks is incorrect Jan 4, 2024
@jeddy3 jeddy3 changed the title Fix: Template literal behavior with line breaks is incorrect Fix function-no-unknown|value-keyword-case false positives for template literals with line breaks Jan 7, 2024
@jeddy3 jeddy3 changed the title Fix function-no-unknown|value-keyword-case false positives for template literals with line breaks Fix function-no-unknown|value-keyword-case false positives for template literals with line breaks Jan 7, 2024
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@ybiquitous ybiquitous merged commit 4e58390 into stylelint:main Jan 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix function-no-unknown|value-keyword-case false positives for template literals with line breaks
3 participants