Fix declaration-block-no-redundant-longhand-properties false negatives for overflow, overscroll-behavior, scroll-margin, scroll-padding, and new Box Alignment shorthands
#7213
Conversation
🦋 Changeset detectedLatest commit: 8118835 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Going to unmark this as draft, but before we merge this - I think a clearer PR title is necessary (which I'll then put into the changeset for this, which will be a patch). While this would be accurate:
It is likely too long. Any suggestions? |
Surely, it's long bug clear to me. I think it's not a problem. 👍🏼 |
Please add all the properties either in the changelog partial or the commit message during the squash.
👍 |
lib/rules/declaration-block-no-redundant-longhand-properties/__tests__/index.mjs
Outdated
Show resolved
Hide resolved
mattxwang
changed the title
declaration-block-no-redundant-longhand-properties false negativesdeclaration-block-no-redundant-longhand-properties false negatives for overflow, overscroll-behavior, scroll-margin, scroll-padding, and new Box Alignment shorthands
Ref: #7200 (comment) & other missing shorthands.
Wasn't sure about
background-positionorborder-image-widthin the linked issue, so I left a comment.Any thoughts on how to name this PR?
Current properties:
gap: 94% on caniuseoverflowoverscroll-behaviorplace-content: 95% on caniuseplace-items: 95% on caniuseplace-self: 95% on caniusescroll-margin(we already supported theblock/inlineproperties)scroll-padding(we already supported theblock/inlineproperties)Properties in the shorthand list that I'm choosing not to do (but could bundle in?):
container: 88% on caniuse. I think this is supported by all major browsers, but is slightly smaller than the other shorthands we've supportedcontain-intrinsic-size: 74% on caniuse, which seems low?font-synthesis: 92% on caniuse, but the way this shorthand behaves is a bit different than the standard shorthand (it's almost like a flag?) so I'll do this in a different PRfont-variant: 96% on caniuse same asfont-synthesisre: shorthand behaviorscroll-timeline: 62% on caniuse, definitely too low!