Fix declaration-block-no-redundant-longhand-properties false negatives for *-block and *-inline logical properties
#7208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ves for `margin-block` and `margin-inline` This is the original ask in #7200.
🦋 Changeset detectedLatest commit: 9b09883 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ves for `padding-block` and `padding-inline`
mattxwang
changed the title
declaration-block-no-redundant-longhand-properties false negativesdeclaration-block-no-redundant-longhand-properties false negatives for *-block and *-inline logical properties
|
Going to mark this as ready-for-review since I think it's big enough! |
ybiquitous
reviewed
Oct 3, 2023
mattxwang
force-pushed
the
reduce-false-negatives-decl-blk-no-red-lng-props
branch
from
00e2315
to
9b09883
Compare
Ah! Totally slipped my mind, thanks. Just added those and sorted the list alphabetically (I'm not sure what the previous order was). (accidentally force-pushed - sorry about that! only the latest commit is different from the last review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7200.
Bundling many properties into this PR as suggested in the original issue. I'm only including the ones that are trailed with
-blockand-inline(as scoped in the original issue title); I will address further false negatives in another PR.I've chosen to base this off of
mainsince:v16Affected properties:
border-blockborder-inlineinset-blockinset-inlinescroll-margin-blockscroll-margin-inlinescroll-padding-blockscroll-padding-inlinemargin-blockmargin-inlinepadding-blockpadding-inline